-
Notifications
You must be signed in to change notification settings - Fork 142
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(da): increase backoff for mempool errors (#1535)
## Overview This PR increases the backoff duration for mempool errors, avoiding the scenario where a temporary mempool error e.g due to congestion can exhaust all retries. Fixes #1522 ## Checklist - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a default expiration time for mempool transactions to improve transaction management. - Enhanced block submission with handling for `maxBlobSize` and `gasPrice`, offering better flexibility and efficiency. - Added a new flag in `rollkit start` command for setting DA gas price multiplier, facilitating more robust transaction retries. - **Improvements** - Extended the submission timeout period from 60 to 90 seconds, allowing for more reliable block submissions under network delays. - Enriched error messaging and introduced new status codes for block submission to improve debugging and operational transparency. - **Refactor** - Replaced `MockDA` struct with `mock.MockDA` in tests for a more streamlined testing approach. - Implemented a mock `DA` interface in `da/mock/mock.go`, enhancing testability and development efficiency. - **Tests** - Updated various test functions to accommodate new parameters and improved error handling, ensuring the reliability of changes. - **Documentation** - Documented the addition of the DA gas price multiplier flag in `rollkit start` command usage. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
- Loading branch information
Showing
13 changed files
with
238 additions
and
90 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.