fix: improperly quoted tags values in 1password.1pif test asset #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@roddhjav There you go. |
|
What's the most likely time window for the next release ? |
|
Nice, thanks a lot. Merged! Next release should come soon (it is about time). |
@roddhjav At this point, a production system I maintain needs a new pass-import official release with the fixes I contributed to/merged ~3weeks ago. Is that something that can be done within this week/next week ? |
|
That is now done. |
|
Fantastic! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: improperly quoted tags values in 1password.1pif test asset #209
Values were single quoted instead of double quoted.
doc: filter dependency for pip based installs
self explanatory.
PS: Thank for conditional test runs code to reduce the noise.