This repository has been archived by the owner on Oct 2, 2021. It is now read-only.
Fixing leap year, year < 2000, optimising #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rule is not only if the year is divisible by for but : * if the year is divisible by 4 and not divisible by 100, or * if the year is divisible by 400
Jorropo
changed the title
|
I have move my repo to github.com/Jorropo/ds3231/ |
|
hello. first of all thanks for your pull request. the minimum and maximum values expected for the year are 1970 (start of unixtime, since we don't support negative uint32_t) and 2032 - when unsigned uint32_t will overflow. cheers, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rule for leap year is not only if the year is divisible by for but :
en.wikipedia.org/wiki/Leap_year#Algorithm
For a simple pr review check in diff option : "hide white space"