Close #633 - Fixed characters encoding in repository credentials

rocketeers · Jul 10, 2016 · 7f18f39 · 7f18f39
1 parent 725d8c6
commit 7f18f39
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,12 @@
 
 Rocketeer follows the [Semantic Versioning 2.0](http://semver.org/spec/v2.0.0.html) spec.
 
+## [2.2.1] - Unreleased
+
+### Fixed
+- Rocketeer now uses the `composer.json` as source of truth for which extensions to check against
+- Fixed characters encoding in repository credentials
+
 ## [2.2.0] - 2015-04-04
 
 ### Added

diff --git a/src/Rocketeer/Services/Connections/ConnectionsHandler.php b/src/Rocketeer/Services/Connections/ConnectionsHandler.php
@@ -406,6 +406,8 @@ public function getRepositoryEndpoint()
 
         // Add credentials if possible
         if ($username || $password) {
+            $username = urlencode($username);
+            $password = urlencode($password);
 
             // Build credentials chain
             $credentials = $password ? $username.':'.$password : $username;