Skip to content
This repository has been archived by the owner on Sep 5, 2020. It is now read-only.

Commit

Permalink
Fix silent commands still being output
Browse files Browse the repository at this point in the history
  • Loading branch information
@Anahkiasen
Anahkiasen committed Feb 8, 2014
1 parent 7f57ff7 commit 7a83c61
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/Rocketeer/Traits/BashModules/Core.php
View file
Expand Up @@ -56,7 +56,7 @@ public function getHistory()
public function run($commands, $silent = false, $array = false)
{
$commands = $this->processCommands($commands);
$verbose = $this->getOption('verbose') and !$silent;
$verbose = $this->getOption('verbose') && !$silent;

// Log the commands for pretend
if ($this->getOption('pretend') and !$silent) {
Expand All @@ -70,7 +70,7 @@ public function run($commands, $silent = false, $array = false)
$output .= $results;

if ($verbose) {
$me->remote->display($results);
$me->remote->display(trim($results));
}
});

Expand Down

1 comment on commit 7a83c61

@ShonM
Copy link
Contributor

@ShonM ShonM commented on 7a83c61 Feb 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intentionally use leading space in some command outputs for formatting purposes, so for me rtrim() works better here. Is that something you might consider looking into now that so much time has passed?

Please sign in to comment.