Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name all the Runtime_arg being created #30

Closed
wants to merge 1 commit into from
Closed

name all the Runtime_arg being created #30

wants to merge 1 commit into from

Conversation

hannesm
Copy link
Collaborator

@hannesm hannesm commented May 9, 2024

No description provided.

@hannesm
Copy link
Collaborator Author

hannesm commented May 9, 2024

to be honest, I don't know whether we need this or not... - but it looks not nice to have some passing ~name, while others don't... (i.e. ssh_key always passed that name)...

@reynir
Copy link
Contributor

reynir commented May 9, 2024

Runtime_arg.create is undocumented (!?) and I can't quite figure out what name is used for except as an identifier in generated code (maybe). I'll open an issue on mirage/mirage. In the meantime I'm not able to properly review this...

@hannesm
Copy link
Collaborator Author

hannesm commented May 17, 2024

since that will change in 4.5.1, we'll remove these names.

@hannesm hannesm closed this May 17, 2024
@hannesm hannesm deleted the name-keys branch May 17, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants