Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unikernel arguments section #29

Closed
wants to merge 2 commits into from
Closed

Use unikernel arguments section #29

wants to merge 2 commits into from

Conversation

reynir
Copy link
Contributor

@reynir reynir commented May 9, 2024

@hannesm
Copy link
Collaborator

hannesm commented May 9, 2024

I suggest two things:

  • let's bind "let docs = Mirage_runtime.s_arg" and use ~docs in all the keys (this way, we don't introduce another indirection/function for no obvious good reason)
  • Also, in config.ml we should use the Mirage_runtime.s_log for the respective keys...

@hannesm
Copy link
Collaborator

hannesm commented May 20, 2024

I integrated part into 5d5b7c3, and since mirage 4.5.1 now does a reasonable ordering of the sections, no need to put each argument into a specific section.

@hannesm hannesm closed this May 20, 2024
@hannesm hannesm deleted the section-unikernel branch May 20, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants