Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoundFileMp3 and ffmpegPortmonitor: Fix compatibility with ffmpeg 7 #3109

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

traversaro
Copy link
Member

I based my modifications on the modifications done in decode_audio and encode_audio examples in ffmpeg, see the modifications in FFmpeg/FFmpeg@f5ef91e .

Note that LIBAVCODEC_VERSION_MAJOR==61 corresponds to ffmpeg 7, see https://github.com/FFmpeg/FFmpeg/blob/n7.0/libavcodec/version_major.h#L28 .

Copy link

update-docs bot commented May 15, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in doc/release/<target_branch>, based on your changes.

@traversaro traversaro changed the title SoundFileMp3: Fix compatibility with ffmpeg 7 SoundFileMp3 and ffmpegPortmonitor: Fix compatibility with ffmpeg 7 May 15, 2024
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
71.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@randaz81 randaz81 merged commit 2c1ff12 into robotology:master Jun 3, 2024
49 of 50 checks passed
@randaz81 randaz81 added this to the YARP 3.10.0 milestone Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants