Do not ignore ${SWIG_DIR} when invoking ${SWIG_EXECUTABLE} #3108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
had a problem deploying
to
code-analysis
GitHub Actions
Failure
traversaro
temporarily deployed
to
code-analysis
GitHub Actions
Inactive
traversaro
temporarily deployed
to
code-analysis
GitHub Actions
Inactive
|
randaz81
approved these changes
Jun 3, 2024
randaz81
added
the
Component: Bindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix, the compilation with a custom non-system swig is failing. See https://github.com/Kitware/CMake/blob/v3.29.2/Modules/UseSWIG.cmake#L725 for similar code inside CMake.
This is important for compatibility with Ubuntu 24.04 when using apt dependencies, as the swig that ships with Ubuntu 24.04 is swig 4.2.0, that is not compatible with YARP.