added device for synchronization #2772
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ste93
requested review from
drdanz,
Nicogene,
randaz81 and
traversaro
as code owners
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in |
PeterBowman
reviewed
Dec 6, 2021
PeterBowman
suggested changes
Dec 7, 2021
| close(); | ||
| return false; | ||
| } | ||
| port_pointers_list.push_back(current_port); |
There was a problem hiding this comment.
This should go before the if clause, otherwise the newly constructed current_port will not be accessible by the close handler for deletion, thus causing a memory leak.
| bool SystemReady_nws_yarp::close() | ||
| { | ||
| for (auto elem: port_pointers_list){ | ||
| elem->close(); |
There was a problem hiding this comment.
There used to be a delete here in previous revisions, it needs to be kept to avoid memory leaks.
randaz81
force-pushed
the
master
branch
3 times, most recently
from
71900d2
to
ead1caf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systemReady {#master}
yarp
devices