Catkin Lint

[jihoonl]

Have tested catkin_lint with all rocon packages.

catkin_lint: checked 77 packages and found 47 problems
catkin_lint: 3 warnings have been ignored. Use -W1 to see them
catkin_lint: 15 notices have been ignored. Use -W2 to see them
capabilities: error: run_depend 'message_runtime' is not listed in catkin_package()
capabilities: error: message dependency 'std_srvs' is not listed in catkin_package()
capabilities: error: message dependency 'std_msgs' is not listed in catkin_package()
capabilities: error: unconfigured build_depend on 'roslaunch'
capabilities: error: unconfigured build_depend on 'rospy'
concert_conductor_graph: CMakeLists.txt(52): error: duplicate catkin_package()
concert_teleop_app: CMakeLists.txt(52): error: duplicate catkin_package()
gateway_msgs: error: missing build_depend on 'genmsg'
gateway_msgs: error: unconfigured build_depend on 'message_generation'
gateway_msgs: error: unconfigured build_depend on 'message_generation'
opp_demo: error: unknown run_depend 'annotations_store'
rocon_admin_app: CMakeLists.txt(52): error: duplicate catkin_package()
rocon_app_manager_msgs: error: unconfigured build_depend on 'rocon_service_pair_msgs'
rocon_gateway_tests: error: unconfigured build_depend on 'rocon_test'
rocon_gateway_tests: error: unknown test_depend 'unittest'
rocon_gateway_tests: CMakeLists.txt(12): error: missing COMPONENTS keyword before 'rocon_test'
rocon_gateway_tutorials: error: file setup.py found but no catkin_python_setup() call
rocon_gateway_utils: error: unconfigured build_depend on 'rostest'
rocon_gateway_utils: CMakeLists.txt(22): error: duplicate find_package(catkin)
rocon_gateway_utils: CMakeLists.txt(22): error: missing COMPONENTS keyword before 'rosunit'
rocon_gateway_utils: CMakeLists.txt(22): error: missing COMPONENTS keyword before 'rostest'
rocon_gateway_utils: CMakeLists.txt(22): error: catkin_package() is called before find_package()
rocon_interaction_msgs: error: unconfigured build_depend on 'uuid_msgs'
rocon_interactions: error: missing build_depend on 'rostest'
rocon_interactions: tests/ros/CMakeLists.txt(5): error: duplicate find_package(catkin)
rocon_interactions: tests/ros/CMakeLists.txt(5): error: catkin_package() is called before find_package()
rocon_python_comms: tests/CMakeLists.txt(17): error: duplicate find_package(catkin)
rocon_python_comms: tests/CMakeLists.txt(17): error: catkin_package() is called before find_package()
rocon_python_utils: error: unconfigured build_depend on 'rostest'
rocon_python_utils: CMakeLists.txt(22): error: duplicate find_package(catkin)
rocon_python_utils: CMakeLists.txt(22): error: missing COMPONENTS keyword before 'rostest'
rocon_python_utils: CMakeLists.txt(22): error: missing COMPONENTS keyword before 'rosunit'
rocon_python_utils: CMakeLists.txt(22): error: catkin_package() is called before find_package()
rocon_remocon: CMakeLists.txt(51): error: duplicate catkin_package()
rocon_scheduler_requests: error: unconfigured build_depend on 'scheduler_msgs'
rocon_scheduler_requests: tests/CMakeLists.txt(12): error: duplicate find_package(catkin)
rocon_scheduler_requests: tests/CMakeLists.txt(12): error: catkin_package() is called before find_package()
rocon_std_msgs: error: missing build_depend on 'genmsg'
rocon_std_msgs: error: unconfigured build_depend on 'message_generation'
rocon_std_msgs: error: unconfigured build_depend on 'uuid_msgs'
rocon_std_msgs: error: unconfigured build_depend on 'message_generation'
rocon_test: error: unconfigured build_depend on 'rostest'
rocon_tf_reconstructor: error: exported library 'rocon_tf_reconstructor_lib' cannot have different output name
rocon_unreliable_experiments: error: build include path 'include' does not exist
rqt_capabilities: error: rqt_gui plugin file 'plugin.xml' is not installed to ${{CATKIN_PACKAGE_SHARE_DESTINATION}}
scheduler_msgs: error: run_depend 'message_runtime' is not listed in catkin_package()
turtle_concert: error: build include path 'include' does not exist

[jihoonl]

FTI catkin_lint : https://github.com/fkie/catkin_lint

[stonier]

Awesome.

I was just about to try that as well. And it looks like it will really help
with an upcoming release. I was starting to not look forward to that day
since everyone has worked in dev for a long time with little focus (or in
some cases haven't had to know about yet) on install issues.

On 14 March 2014 14:22, Jihoon Lee notifications@github.com wrote:

FTI catkin_lint : https://github.com/fkie/catkin_lint

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/10#issuecomment-37617738
.

Phone : +82-10-5400-3296 (010-5400-3296)
Home: http://snorriheim.dnsdojo.com/
Yujin R&D: http://rnd.yujinrobot.com/

[stonier]

Does it have a cmake api?

[jihoonl]

It is described in his github document. https://github.com/fkie/catkin_lint

Copied from his README.

Catkin Build Integration

It is recommended to run catkin_lint at workspace configuration time. The simplest way is to symlink /opt/ros/$ROS_DISTRO/share/catkin/cmake/toplevel.cmake to your $WSDIR/src folder manually (do not use catkin_init_workspace). Then add the following CMakeLists.txt:

cmake_minimum_required(VERSION 2.8.3)
execute_process(COMMAND catkin_lint "${CMAKE_SOURCE_DIR}" RESULT_VARIABLE lint_result)
if(NOT ${lint_result} EQUAL 0)
    message(FATAL_ERROR "catkin_lint failed")
endif()
include(toplevel.cmake)

[stonier]

Ah. Thats awkward. He needs to make a cmake api like I do for rosjava and
jack does for roslint.
On 19 Mar 2014 11:33, "Jihoon Lee" notifications@github.com wrote:

It is described in his github document.
https://github.com/fkie/catkin_lint

Copied from his README.

Catkin Build Integration

It is recommended to run catkin_lint at workspace configuration time. The
simplest way is to symlink
/opt/ros/$ROS_DISTRO/share/catkin/cmake/toplevel.cmake to your $WSDIR/src
folder manually (do not use catkin_init_workspace). Then add the following
CMakeLists.txt:

cmake_minimum_required(VERSION 2.8.3)
execute_process(COMMAND catkin_lint "${CMAKE_SOURCE_DIR}" RESULT_VARIABLE lint_result)
if(NOT ${lint_result} EQUAL 0)
message(FATAL_ERROR "catkin_lint failed")
endif()
include(toplevel.cmake)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/10#issuecomment-38012017
.

[jihoonl]

He would be happy to accept pull request :)

[stonier]

I'm already contributing enough everywhere and this one isn't high priority

• our team are cmake experts ;)

On 19 March 2014 11:43, Jihoon Lee notifications@github.com wrote:

He would be happy to accept pull request :)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/10#issuecomment-38012457
.

Phone : +82-10-5400-3296 (010-5400-3296)
Home: http://snorriheim.dnsdojo.com/
Yujin R&D: http://rnd.yujinrobot.com/

[jihoonl]

Remaining lint jobs

catkin_lint: checked 72 packages and found 21 problems
catkin_lint: 3 warnings have been ignored. Use -W1 to see them
catkin_lint: 7 notices have been ignored. Use -W2 to see them
concert_resource_pool: error: unconfigured build_depend on 'scheduler_msgs'
concert_resource_pool: error: unconfigured build_depend on 'rocon_app_manager_msgs'
concert_resource_pool: error: unconfigured build_depend on 'concert_msgs'
concert_resource_pool: error: unconfigured build_depend on 'rospy'
concert_resource_pool: error: unconfigured build_depend on 'rostest'
concert_resource_pool: error: unconfigured build_depend on 'unique_id'
concert_scheduler_requests: error: unconfigured build_depend on 'scheduler_msgs'
concert_scheduler_requests: tests/CMakeLists.txt(11): error: duplicate find_package(catkin)
concert_scheduler_requests: tests/CMakeLists.txt(11): error: catkin_package() is called before find_package()
concert_simple_scheduler: tests/CMakeLists.txt(6): error: duplicate find_package(catkin)
concert_simple_scheduler: tests/CMakeLists.txt(6): error: catkin_package() is called before find_package()
rocon_gateway_utils: error: missing build_depend on 'rosunit'
rocon_gateway_utils: CMakeLists.txt(22): error: duplicate find_package(catkin)
rocon_gateway_utils: CMakeLists.txt(22): error: catkin_package() is called before find_package()
rocon_interactions: tests/ros/CMakeLists.txt(5): error: duplicate find_package(catkin)
rocon_interactions: tests/ros/CMakeLists.txt(5): error: catkin_package() is called before find_package()
rocon_python_comms: tests/CMakeLists.txt(17): error: duplicate find_package(catkin)
rocon_python_comms: tests/CMakeLists.txt(17): error: catkin_package() is called before find_package()
rocon_python_utils: error: missing build_depend on 'rosunit'
rocon_python_utils: CMakeLists.txt(22): error: duplicate find_package(catkin)
rocon_python_utils: CMakeLists.txt(22): error: catkin_package() is called before find_package()