Search functionality in log files #3933
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a prototype search in log.html for #3799.
The interface was inspired from the old search function in libdoc and it looks like this:
In the search dialog, all the results are links to the keywords in the log file and inside the log the results are highlighted in orange.
A limitation I've encountered is that not all keywords are available from the start in DOM and are not accessible to search through them. A proposal I have is to add a checkbox to
Expand all keywords and search, but maybe there is a better way to do it that I cannot see at the moment.@pekkaklarck any comments and suggestions from you are welcomed :)