Updated supported Python and Selenium versions #1890
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Within setup.py and the Github Actions workflow updated supported versions.
yuriverweij
reviewed
Mar 10, 2024
There was a problem hiding this comment.
Looks good, but selenium made some changes regarding Default_preferences on Firefoxprofile, which causes our unit tests to fail. I was looking into that, and it seems they no longer save the preferences we add to DEFAULT_PREFERENCES, but they are present in _desired_preferences. Changing that in the unit tests makes the test success again, but I'm not sure if that is the correct solution. Also that is not backwards compatible.
|
Resolved in another pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within setup.py and the Github Actions workflow updated supported versions.