Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imporve the indexing function for the pages screenshot. #1840

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on Jun 14, 2023

  1. Replace index to by timestamp option based on YY-MM-DD_HH-MM-SS into …

    …_get_screenshot_path
    
    /*
    def _get_screenshot_path(self, filename):
            if self._screenshot_root_directory != EMBED:
                directory = self._screenshot_root_directory or self.log_dir
            else:
                directory = self.log_dir
            filename = filename.replace("/", os.sep)
            YY_MM_DD_HH_MM_SS = datetime.datetime.now().strftime('%Y-%m-%d_%H-%M-%S')
            while True:
                YY_MM_DD_HH_MM_SS = datetime.datetime.now().strftime('%Y-%m-%d_%H-%M-%S')
                formatted = _format_path(filename, YY_MM_DD_HH_MM_SS)
                path = os.path.join(directory, formatted)
                # filename didn't contain {YY_MM_DD_HH_MM_SS} or unique path was found
                if formatted == filename or not os.path.exists(path):
                    return path
    */
    
    This action is inprogress
    AmirHdm committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    195f0de View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Modifiy the index for screenshot to the following structure :

    Selenium-Screenshot-{index}
    index : 'YYYY-MM-DD-HH-MM-SS-RANDOM
    AmirHdm committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    6112fa6 View commit details
    Browse the repository at this point in the history
  2. Fix Index name

    AmirHdm committed Jun 15, 2023
    Configuration menu
    Copy the full SHA
    6f40417 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. Add indexing with timestamp or a numeriacl randon for page capture fe…

    …ature
    
    Add formatting functions for a randon & timestamp  placeholders
    AmirHdm committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    d5b888c View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. Update file name with filename: str = 'selenium-screenshot-{index} or…

    … {random} or {timestamp}.png'
    
    Add three indexing option : index / random / timestamp
    AmirHdm committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    446bead View commit details
    Browse the repository at this point in the history