Avoid loading unused internal plugins #949
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The four "internal" plugins [
openmhz_uploader
,broadcastify_uploader
,stat_socket
,unit_script
] are always loaded, whether or not the user intends to use them in their trunk-recorder installation.After the configuration file is parsed, this PR checks if any of the mandatory configuration keys for the above plugins are present before adding them to the load list. This will reduce unnecessary API calls, and avoid the overhead of loading a plugin in duplicate should the user consolidate the configuration into the "plugins" section as shown in the example below:
"Internal" plugins (other than stat_socket) can be loaded in "plugin" section if desired. Aside from the convenience of managing a plugin's configuration in a single part of the config file, this also allows the user to toggle the
enabled
key to easily enable/disable a plugin as needed.