Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Base Docker Image to v1.4.5 #49

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bump Base Docker Image to v1.4.5 #49

wants to merge 3 commits into from

Conversation

strongishllama
Copy link

Bumps the base Docker image to v1.4.5 which solves an issue with the current version of curl being used, see below.

INFO: Looking for an existing plan PR comment.
Error relocating /usr/bin/curl: curl_easy_nextheader: symbol not found
Error relocating /usr/bin/curl: curl_easy_header: symbol not found
INFO: No existing plan PR comment found.
INFO: Adding plan comment to PR.
Error relocating /usr/bin/curl: curl_easy_nextheader: symbol not found
Error relocating /usr/bin/curl: curl_easy_header: symbol not found

It might also be worth pinning the curl version (and the versions of the other packages used) so this doesn't happen in the future 馃槃

Taliesin Millhouse and others added 2 commits April 14, 2023 11:26
@bchrobot bchrobot mentioned this pull request Apr 14, 2023
Open
janhartje
janhartje approved these changes Apr 18, 2023
View reviewed changes
Copy link

@janhartje janhartje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janhartje
Copy link

@robburger hi could you please accept this pr? Currently the action isn't working as expected.

@sxarp
Copy link

sxarp commented May 19, 2023

Thank you so much!
It starts working after changing as follows!

        uses: MaxKelsen/terraform-pr-commenter@b26c5af94b96ac4a6a32750b6fdc426ef2d9cd4c

jonathanhle
jonathanhle approved these changes May 22, 2023
View reviewed changes
Copy link

@jonathanhle jonathanhle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meyerbro
Copy link

@robburger can you merge?

@ms-ati
Copy link

ms-ati commented Jun 6, 2023

@robburger are you no longer maintaining? Can you please mark this as archived or otherwise help the community move to a fork?

mherzig added a commit to pathstream/terraform-pr-commenter that referenced this pull request Oct 3, 2023
@mherzig
Update Dockerfile
740bef9 
We've had to bump versions a couple of times when we hit curl issues as documented [here](robburger#49). If at some point this latest tag isn't usable, we could always try to pin to a slightly older version but be aware that a few months later, curl might start acting up again.
@gfkeith gfkeith mentioned this pull request Nov 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanhle jonathanhle jonathanhle approved these changes

@janhartje janhartje janhartje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@strongishllama @janhartje @sxarp @meyerbro @ms-ati @jonathanhle @grumpydude