Update engine to precompile graphiql assets #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyjellis
pushed a commit
to wesleyjellis/sprockets_graphql
that referenced
this pull request
Oct 23, 2019
|
I can confirm this works on https://github.com/wesleyjellis/sprockets_graphql/tree/precompile |
|
Hello Robert @rmosolgo :) I can confirm that the provided fix indeed does the job and is also the expected way to go (at least according to the Rails Guides). Do you mind reviewing this and in case you agree with it, also merging and releasing it? I'm in the process of updating the How to GraphQL Ruby tutorial for Rails 6 and I'd like to avoid adding an instruction for the users to add the graphiql-assets in the manifest.js of their application. |
AlexVPopov
pushed a commit
to AlexVPopov/howtographql
that referenced
this pull request
Nov 20, 2019
These instructions are needed as Sprockets 4 changes the logic for which assets are to be included for precompilation by default. They can be removed once rmosolgo/graphiql-rails#76 is merged and released.
AlexVPopov
pushed a commit
to AlexVPopov/howtographql
that referenced
this pull request
Jan 6, 2020
These instructions are needed as Sprockets 4 changes the logic for which assets are to be included for precompilation by default. They can be removed once rmosolgo/graphiql-rails#76 is merged and released.
AlexVPopov
pushed a commit
to AlexVPopov/howtographql
that referenced
this pull request
Jan 13, 2020
* update instructions for generating the LinkType
* bump graphiql-rails version to 1.7.0
* update explanation about fields resolution
* add instructions for adding GraphiQL assets to manifest.js
- These instructions are needed as Sprockets 4 changes the logic for
which assets are to be included for precompilation by default. They
can be removed once rmosolgo/graphiql-rails#76
is merged and released.
|
Hi @rmosolgo. Do you have plans to release a new version of this gem soon? It would be great if this PR could be merged into it. |
AlexVPopov
pushed a commit
to AlexVPopov/howtographql
that referenced
this pull request
Feb 16, 2020
* update instructions for generating the LinkType
* bump graphiql-rails version to 1.7.0
* update explanation about fields resolution
* add instructions for adding GraphiQL assets to manifest.js
- These instructions are needed as Sprockets 4 changes the logic for
which assets are to be included for precompilation by default. They
can be removed once rmosolgo/graphiql-rails#76
is merged and released.
|
Sorry for the delay, and thanks for the fix! I'll cut a new release later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #75
This is my first PR against an open-source project. I'm not sure if there's a better way to address this issue but this seems to work. Happy to get any feedback or iterate on this. I didn't see guidelines for contributing so please let me know if I can make this PR better!