Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serialport -> rubyserial, Travis CI Ruby version updates, Bundler restriction lift #58

Closed
wants to merge 5 commits into from
Closed

serialport -> rubyserial, Travis CI Ruby version updates, Bundler restriction lift #58

wants to merge 5 commits into from

Conversation

joealba
Copy link
Contributor

@joealba joealba commented Nov 1, 2019

  • Switch from the serialport gem to the rubyserial gem - use rubyserial instead of serialport #46
  • Update the versions of MRI Ruby that get tested in Travis to the latest supported versions
  • Remove jruby from Travis, as it fails to build the serialport gem
  • Remove the overly-strict restriction on the version of Bundler to help folks with more recent installs have an easier time contributing
  • Whitespace-only: Make the gem dependency formatting consistent

@joealba joealba changed the title Dependency updates serialport -> rubyserial, Travis CI Ruby version updates, Bundler restriction lift Nov 1, 2019
@fmluizao
Copy link
Collaborator

Hi @joealba, thanks for your contribution!

About rubyserial, It seems to lack flush_input and flush_output and blocking read. I'm not sure if flushing is necessary, but blocking read is... did you test with a real device?

@joealba
Copy link
Contributor Author

joealba commented Jun 29, 2020

@fernandoluizao My apologies, I was relying on the comment in the RubySerial readme that its interface was "(mostly)" compatible with other implementations. I did not test on a real device.

@fmluizao
Copy link
Collaborator

I would love to switch to rubyserial, mostly for jruby compatibility... unfortunately I don't have a device with a serial port to test.

I'll cherry-pick the other commits, and leave the rubyserial change for later, until we can make sure rubyserial works without more changes.

@fmluizao fmluizao closed this Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants