New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setInterval will clear itself when element is removed from the DOM #98

Open

scotthovestadt wants to merge 3 commits into rmm5t:master from scotthovestadt:master

scotthovestadt commented Nov 15, 2012

My use-case is an activity feed with only 5 items. However, over the lifetime of the web application, thousands of items pass through the feed.

It was not ideal to have thousands of setInterval calls fire each minute.

scotthovestadt added 3 commits

November 15, 2012 11:04


          setInterval will clear itself when element removed

63ab5d0

setInterval will clear itself when element is removed from the DOM.


          Updated to deal with multiple elements.

61d3bc3

Credit to tangphillip.


          Changed Function.call to refresh.call

439dfd0

rupurt commented Sep 25, 2013

Any word on this issue? Single page apps are becoming more common and timeago needs the ability to remove itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment