Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed computation of date diff #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

synalysis
Copy link

Result was wrong if date diff is almost a day:

Date1: <Tue Sep 18 2018 18:00:00 GMT+0300 (EEST)>
Date2: <Mon Sep 17 2018 18:41:37 GMT+0300 (EEST)>
Duration: { year = 0, month = 0, day = 0, hour = 59, minute = 18, second = 22, millisecond = 80 }

Result was wrong if date diff is almost a day:

Date1: <Tue Sep 18 2018 18:00:00 GMT+0300 (EEST)>
Date2: <Mon Sep 17 2018 18:41:37 GMT+0300 (EEST)>
Duration: { year = 0, month = 0, day = 0, hour = 59, minute = 18, second = 22, millisecond = 80 }
@rluiten
Copy link
Owner

rluiten commented Oct 24, 2018

Well spotted :)

Sorry for slow response I just noticed this message was still in my browser from weeks ago I had not sent the comment.

I have been fairly busy lately, I hope to have a look at publishing this soon in near future.
Ill have to install Elm 0.18, to do this change, as i moved to Elm 0.19 to update some other libs so will have to setup.

At the moment I am not sure I will update this library to Elm 0.19, due to many changes in the new platform.

@synalysis
Copy link
Author

Currently I use my fork with the fix so at least for me there is no need to have it fixed in the 0.18 version. Better invest your time looking forward :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants