Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]factorize “the estimated predicted error covariance” #189

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Capsellab
Copy link

You should factorize “the estimated predicted error covariance” on formula (43) , before "3)Evaluate the propagated cubature points" in the Measurement Update section.

Copy link
Owner

@rlabbe rlabbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not run, as sigmas_f does not exist.

I suspect you meant to write this in the predict code:
sigmas = spherical_radial_sigmas(self.x, self.P)

    # evaluate cubature points
    for k in range(self._num_sigmas):
        sigmas[k] = self.fx(sigmas[k], dt, *fx_args)

    self.x, self.P = ckf_transform(sigmas, self.Q)

but am not sure. I haven't looked at cubature filters in a long time.

Ideal check ins include a new test (in the \tests subdirectory) that will fail on the old code, and pass on the new code, otherwise it is often impossible for me to really ascertain the effect of the change and whether it is valid or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants