libsys: Add functions to read the environment variables without passing envp #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After this PR is merged I have the next PR in my fork at https://github.com/samu698/Bear/tree/remove-envp 😉 |
rizsotto
requested changes
Jan 26, 2023
| } | ||
|
|
||
| const Vars& get() | ||
| { |
There was a problem hiding this comment.
This method does not look good to me! 😄 Static variables are source of bugs in my books.
The static variables can be avoided by change the return type by value (instead of by reference). You can still can capture the return value as const auto & to avoid copying. We shall just rely on compiler return value optimization then declaring static variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions
sys::env::getandsys::env::get_envpallow to read the environment vars directly from theenvironextern and it will allow to remove all the envp arguments passed to functions.