fix: NoBrowser when server is running #2674
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the NoBrowser setting is true, a browser should not be opened even if the server is already running. The existing version doesn't open a browser the first time the server starts, but then does open a one if the goOnline command is called again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the NoBrowser setting is true, a browser should not be opened even if the server is already running. The existing version doesn't open a browser the first time the server starts, but then does open one if the goOnline command is called again.
PR Type
What kind of change does this PR introduce?
[x] Bugfix [ ] Feature [ ] Refactoring (no functional changes, no api changes) [ ] Documentation content changes [ ] Other: <!-- Please describe: -->What is the current behavior?
Issue Number: #2673
What is the new behavior?
A browser is never opened when the NoBrowser option is set to true.
Does this PR introduce a breaking change?