Add the verifier contract address to docs for v0.10.0 #1727
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
Is |
|
Ohh, that's based on the numbering on |
| | [RiscZeroGroth16Verifier.sol] | [Sepolia] | [0xe57255C10291771A2E14f7eb257555AE82D78302][sepolia-verifier] | | ||
| | Contract | Version | Network | Address | | ||
| | ----------------------------- | ---------------------------- | --------- | ---------------------------------------------------------------------- | | ||
| | [RiscZeroGroth16Verifier.sol] | [v0.9.0][contracts-v0.9.0] | [Sepolia] | [0xe57255C10291771A2E14f7eb257555AE82D78302][sepolia-verifier-v0.9.0] | |
There was a problem hiding this comment.
Currently clicking on either of the links in the contract column will land you on the v0.8 version of the contract.
There was a problem hiding this comment.
As for the deployed contracts, I've realized that this is a "corporate needs you to find the difference between this contract and this contract" situation.... there were no changes to the verifier between 0.9 and 0.10. (Evidence git diff v0.9.0..v0.10.0 --stat -- contracts)
| | Contract | Network | Address | | ||
| | ----------------------------- | --------- | -------------------------------------------------------------- | | ||
| | [RiscZeroGroth16Verifier.sol] | [Sepolia] | [0xe57255C10291771A2E14f7eb257555AE82D78302][sepolia-verifier] | | ||
| | Contract | Version | Network | Address | |
There was a problem hiding this comment.
Do we want a column here indicating the control root and/or list of allowed programs?
Or perhaps we want a separate table for tracking versioning for the control root?
There was a problem hiding this comment.
I do like the simplicity of this table, so I'm hesitant to complicate it with the very technical implementation detail of the control root.
On the other hand, as a user, I'd like to have a way to confirm that the control root being used corresponds to the set of zkr programs I trust.
There was a problem hiding this comment.
Best way for someone to check this is to look at the verified source code for the contract on Etherscan, pull the control root out of there, and verify it by recomputing it from the risc0 repo. We should indeed include instructions on how to do this, probably in a comment above the control root field in the contract source, and potentially elsewhere.
…fier-contract-addr-v0.10.0
Add the verifier contract address to docs for v0.10.0