allow configuring rust toolchain branch

[austinabell]

Not sure if this is correct, just opening for visibility to help unblock someone needing to build the toolchain given the updated Rust version (1.70 too low).

Also changes the clone to minimize data fetched. Removed this for simplicity, it was causing weird edge case issues

Ignore this PR, unless you also want this.

Tested with:

cargo install --force --path risc0/cargo-risczero
cargo risczero build-toolchain --git-tag v2024-04-22.0

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
docs-website	✅ Ready (Inspect)	Visit Preview	Apr 25, 2024 10:31pm
reports-and-benchmarks	✅ Ready (Inspect)	Visit Preview	Apr 25, 2024 10:31pm

[flaub]

Not sure we need this?

[austinabell]

Needed because if the branch/tag is created after you clone, it won't resolve? Maybe I'm overlooking something, though

[flaub]

I think we should try to use a git ref rather than a branch name so that it's more generic. Some adjustments might need to be made to allow for this.

[austinabell]

I think we should try to use a git ref rather than a branch name so that it's more generic. Some adjustments might need to be made to allow for this.

This does work with tags and refs, just tested refs also to double check, that's why I had the naming as tags (seemed most generic).

[flaub]

My understanding is that git clone --branch only takes branches and tags, but not a commit hash: https://git-scm.com/docs/git-clone#Documentation/git-clone.txt---branchltnamegt

Instead of pointing the newly created HEAD to the branch pointed to by the cloned repository’s HEAD, point to branch instead. In a non-bare repository, this is the branch that will be checked out. --branch can also take tags and detaches the HEAD at that commit in the resulting repository.

So my thinking is to drop the --branch on clone and let the following checkout command do the switch.

[austinabell]

My understanding is that git clone --branch only takes branches and tags, but not a commit hash: git-scm.com/docs/git-clone#Documentation/git-clone.txt---branchltnamegt

Instead of pointing the newly created HEAD to the branch pointed to by the cloned repository’s HEAD, point to branch instead. In a non-bare repository, this is the branch that will be checked out. --branch can also take tags and detaches the HEAD at that commit in the resulting repository.

So my thinking is to drop the --branch on clone and let the following checkout command do the switch.

You're right! I missed testing that case without a cloned branch. That was more of an artifact from trying to pull only what was needed.

I'll run the cases in the background and make that change now, good catch