Fix send_recv_slice when U != u8 #1620
Open
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
@hashcashier did this fix your issue? |
|
Is there a test we can write which shows the issue? |
friendly ping! @hashcashier could you answer this question? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
send_recv_slice, which is used to allow the host to define "custom syscalls" has a bug which means that it only works when the generic typeUisu8. This is because the host returns to the guest a length for how many bytes it will send to the guest on the next call. The guest code currently interprets this number of bytes to be a number of elements of typeU. So whenmem::size_of::<U> != 1, the length will be incorrect and the second read will fail.