Restore the getrandom feature in rust-runtime.a static lib #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@nategraf it looks like you have some other changes in addition to the getrandom feature |
|
Sorry, yes. I was working on getting |
|
I think we need to get some CI around this staticlib. Ideally we'd run |
|
superseded by #1750. closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore the getrandom feature in
rust-runtime.astatic lib. This static library build primarily supports thecargo risczero testtool, which we use in our workflows to test patched cryptography crates and potentially other crates developed for the zkVM.getrandomis intended to be supported, but was removed with the change of default behavior in #1162.