Remove optimizations from build scripts #1447
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
So I'm looking at this run and #1483 and I'm not seeing a huge difference in execution time but it makes the Cargo.toml's look cleaner, which is nice |
Ya, I'm not exactly sure how best to evaluate this change. Ideally, we see that dev builds are actually faster, and I think that's what should happen, but after opening this PR I realized that watching for CI build times may not be the best signal, especially with |
|
I'm going to do one more test, which is to build the examples from a clean clone and check build times with |
|
I've confirmed that build+run times are reduced with this PR. The effect on overall build times appears to be lower than the noise floor, but some items on the critical path (e.g. |
Throughout our repo we apply optimizations to Cargo build scripts (i.e. binaries built to run as part of the build process). This was introduced to make calculation of control IDs faster, as this was the bottleneck for the build process. Now that control IDs are not calculated on a per-guest basis, it is unclear if optimizing the build scripts is still beneficial to build time. Opening this small PR to see what the build times are in CI across the various examples and tests without this setting. Co-authored-by: Erik Kaneda <erik@risczero.com>
Throughout our repo we apply optimizations to Cargo build scripts (i.e. binaries built to run as part of the build process). This was introduced to make calculation of control IDs faster, as this was the bottleneck for the build process. Now that control IDs are not calculated on a per-guest basis, it is unclear if optimizing the build scripts is still beneficial to build time. Opening this small PR to see what the build times are in CI across the various examples and tests without this setting. Co-authored-by: Erik Kaneda <erik@risczero.com>
Throughout our repo we apply optimizations to Cargo build scripts (i.e. binaries built to run as part of the build process).
This was introduced to make calculation of control IDs faster, as this was the bottleneck for the build process.
Now that control IDs are not calculated on a per-guest basis, it is unclear if optimizing the build scripts is still beneficial to build time.
Opening this small PR to see what the build times are in CI across the various examples and tests without this setting.