Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add
cargo risczero benchmark
command #1302base: main
Are you sure you want to change the base?
Add
cargo risczero benchmark
command #1302Changes from 11 commits
3cf5675
4d9460b
81515a7
5e90ce1
11c9cbf
6baaca7
f37a441
e13ac03
80a8ba8
852500c
e652c76
e1a1bf0
25079ef
2856c23
945f73d
cff8bcd
153b412
fb37fcb
9351187
1ac3c65
fb76458
671a6bf
3f8833c
4572b4e
09a25f0
3f38719
735a6e6
20ff703
9486165
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be dropped, it can't be published
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes!
I was thinking in moving the dependencies we have on
risc0-zkvm-methods
to a new craterisc0-zkvm-methods-core
that we could publish, this way we would solve the issue. That way bothrisc0-zkvm-methods
andcargo-risczero
could depend onrisc0-zkvm-methods-core
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think any of the benchmark binaries need any 'core' crates because the interface is very simple. We pass in the number of iterations to run, so there's no types that need to be shared between host and guest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see... I followed this approach because this would be similar to what we do under
/examples
having acore
that can be used both inguest
andhost
.I did the change before seeing this comment. Please let me know if you'd like to revert the new
risc0-zkvm-methods-core
and I'll change it 🙇♂️