Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collective Perception Service - Service #252

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sodevel
Copy link
Contributor

@sodevel sodevel commented Jul 6, 2022

This is the Collective Perception Service implementation. I rebased it against master to be able to create a PR that doesn't contain the core changes, but it still depends on the changes of #251 to work.

It shouldn't be merged in this state, i use this to gather some feedback what could or should be done first:

  1. There are MANY signals emitted for statistic collection that are of no general use, but maybe some can be kept as example?
  2. The Sensor Information Container is not build correctly and contains one hardcoded entry only. Main reason for this is i didn't know how to properly calculate the sensor position and other meta data required.
  3. The speed value of objects is added as-is instead of relative to the ego vehicle and decomposed into x- and y- speed. This is done mostly for performance reasons, the receiving side needs these values as-is and can spare the calculation roundtrip.
  4. There are added some optional dummy-values to increase the message size, i think these can be removed safely.
  5. The generation rules don't contain the special case for person or animal objects. At the time i wrote this, there were only vehicles available in Artery.
  6. Maybe the additional units and CPM fragment wrappers should be moved into Vanetza instead of beeing part of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant