Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assign wheels_k_ with wheel_separation_x_ and wheel_separation_y_ #35

Open
wants to merge 1 commit into
base: kinetic-devel
Choose a base branch
from

Conversation

onionsflying
Copy link

@onionsflying onionsflying commented Nov 29, 2019

The following codes shouldn't be removed. Otherwise wheels_k_ would remain 0 when the parameters wheel_separation_x_ and wheel_separation_y_ exist.

  bool lookup_wheel_separation = !(has_wheel_separation_x && has_wheel_separation_y);
  bool lookup_wheel_radius = !controller_nh.getParam("wheel_radius", wheels_radius_);

  // Avoid URDF requirement if wheel separation and radius already specified
  if (lookup_wheel_separation || lookup_wheel_radius)
  {
  ...
  }
  else
  {
    ROS_INFO_STREAM("Wheel seperation in X: " << wheel_separation_x_);
    ROS_INFO_STREAM("Wheel seperation in Y: " << wheel_separation_y_);
    // The seperation is the total distance between the wheels in X and Y.
    wheels_k_ = (wheel_separation_x_ + wheel_separation_y_) / 2.0;
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant