Fix Raspbian Buster build for Pi 4 #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are my minimal changes to get things compiling and installing on Buster. Note I also required one outstanding PR on mupen64plus-audio-sdl.
Unless running on a Pi A/A+/B+/0/0w, it's too easy to trip up on
build.shandinstall.shpointing to different default RaspbianLists if someone just glosses that part over in the README. Rather than copypaste the selector conditions intoinstall.shanddev_build.shI added a safeguard around this inbuild.sh.High-level goal is not to break the build flow for Jessie as trunk seems to be designed for, although users will now have to explicitly specify
GCC=4.7for that target.Testing on a Pi 4: I left the video-gles2n64 plugin settings unchanged to avoid breaking existing behavior, but as this plugin is compiled for legacy VideoCore (
VC=1) it's only valid for a Pi <=3B+ in legacy mode. You can test instead with the Rice plugin that doesn't care:Or if you wish to test video-gles2n64 on the Mesa driver, remove
VC=1on the relevant line inRaspbianList_Pi2.