Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and ensure odd-numbered channels have odd numbers #587

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jes
Copy link

@jes jes commented Sep 5, 2018

The logic in availableOutboundChannelId ensured that when a channel needs an even number, an even number is generated, but it did not ensure that when a channel needs an odd number, an odd number is generated.

It worked anyway, so probably the only time it ever needs an odd-numbered id, the number 1 would do, but it seems right to fix the logic anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant