Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of _find api usage #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implementation of _find api usage #10

wants to merge 1 commit into from

Conversation

woutersm
Copy link

Hi Rhinoman,

I've implemented the find api, let me know what you think!

@rhinoman
Copy link
Owner

Hmm... it's fairly rudimentary, requiring the user to pass in a raw byte array for the request body. I'm not very familiar with the new Find API, but I think a more complete implementation of _find might define a struct representing a Find query and the user would pass an instance of a Find struct into the function, rather than (I assume), building their own structure and encoding it to a byte array before passing it in. I think it would be more user-friendly if the function handled such encoding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants