Skip to content
This repository has been archived by the owner on Sep 12, 2021. It is now read-only.

Allow access to component factory for sub-classes. #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow access to component factory for sub-classes. #69

wants to merge 1 commit into from

Conversation

guw
Copy link
Contributor

@guw guw commented Oct 10, 2016

The component factory is used by the content assist. When used outside
of a console page (the Eclipse console view) the content assist needs to
be created manually. Thus, access to the component factory is necessary.

Copy link
Owner

@rherrmann rherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests no merge! ;-)

In this case, the test may also serve as a place to have a comment that points to this issue to explain why the otherwise unused method exists.

In addition, I would declare the method as public to better align with the existing setConsoleComponentFactory()

The component factory is used by the content assist. When used outside
of a console page (the Eclipse console view) the content assist needs to
be created manually. Thus, access to the component factory is necessary.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants