feat: Added getStructuredDataScript util #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r plugin to alter response headers for each page
ambroisemaupate
requested review from
manuelodelain,
timothejoubert and
Illawind
server/plugins/cache-control.ts
Outdated
There was a problem hiding this comment.
The plugin will be automatically loaded and executed by Nuxt. Even if we don't need it. I think plugin into layer is a bit tricky. Maybe we should use a module for this kind of thing? Like a Nuxt module @rezo-zero/nuxt-cache-control who injects the plugin? Another solution would be to nest the plugin into a folder like plugins/cache/cache-controls (not auto loaded) and we could add it manually into the Nuxt config.
There was a problem hiding this comment.
I think a nuxt-module would be preferable.
Every project using a Cache Reverse-Proxy (Varnish, Cloudflare, Vercel) needs to define cache-control header on SSR responses.
ambroisemaupate
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.