Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WiP - CLI Freeform Options #894

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akutz
Copy link
Member

@akutz akutz commented Jun 15, 2017

This patch adds support for the -o|--options flag to add freeform options to outgoing API requests.

This patch adds support for the `-o|--options` flag to add freeform
options to outgoing API requests.
@akutz akutz changed the title CLI Freeform Options WiP - CLI Freeform Options Jun 15, 2017
@codecov-io
Copy link

codecov-io commented Jun 15, 2017

Codecov Report

Merging #894 into master will decrease coverage by 25.39%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #894      +/-   ##
=========================================
- Coverage   34.16%   8.76%   -25.4%     
=========================================
  Files          36      25      -11     
  Lines        2901    2989      +88     
=========================================
- Hits          991     262     -729     
- Misses       1807    2691     +884     
+ Partials      103      36      -67
Impacted Files Coverage Δ
cli/cli/cli.go 0.82% <ø> (ø)
cli/cli/cmds_10_volume.go 0.14% <0%> (ø)
cli/cli/cmds_00_other.go 1.96% <0%> (ø)
libstorage/api/context/context_keys.go
libstorage/api/utils/utils_errors.go
libstorage/drivers/storage/vfs/vfs.go
...ge/drivers/storage/vfs/storage/vfs_storage_snap.go
libstorage/api/utils/utils_config.go
libstorage/api/types/types_config_compat.go
libstorage/api/types/types_auth.go
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a39fd7...d1a099b. Read the comment docs.

Copy link
Member

@codenrhoden codenrhoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good/straightforward. Nothing is consuming these options yet... What is the intent?

@akutz
Copy link
Member Author

akutz commented Jun 16, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants