Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update naming convension for GCP disk #1243

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

boylee1111
Copy link

This patch fixes a bug regarding GCP naming convention.

@CLAassistant
Copy link

CLAassistant commented Jul 9, 2018

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Jul 9, 2018

Codecov Report

Merging #1243 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1243   +/-   ##
=======================================
  Coverage   34.58%   34.58%           
=======================================
  Files          36       36           
  Lines        2362     2362           
=======================================
  Hits          817      817           
  Misses       1441     1441           
  Partials      104      104

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d14c3e3...b4f774a. Read the comment docs.

@clintkitson
Copy link
Member

Hello @boylee1111,

Is this change relevant globally across all GCP instances? Can anyone else validate this change?

@akutz
Copy link
Member

akutz commented Sep 12, 2018

Hi @boylee1111,

Did you see @clintkitson's note above?

Is this change relevant globally across all GCP instances? Can anyone else validate this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants