Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Amazon Linux support in installation script #1200

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jggc
Copy link

@jggc jggc commented Mar 30, 2018

Amazon Linux works well with the RPM package and using the rpm package
improves integration with the distribution. To do that I detect the
distribution name in /etc/system-release.

Also refactored the variables to be consistently using "${}" through the
script.

Amazon Linux works well with the RPM package and using the rpm package
improves integration with the distribution. To do that I detect the
distribution name in /etc/system-release.

Also refactored the variables to be consistently using "${}" through the
script.
@codecov-io
Copy link

codecov-io commented Mar 30, 2018

Codecov Report

Merging #1200 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1200   +/-   ##
=======================================
  Coverage   34.25%   34.25%           
=======================================
  Files          36       36           
  Lines        2362     2362           
=======================================
  Hits          809      809           
  Misses       1450     1450           
  Partials      103      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c38bb7...681b103. Read the comment docs.

@clintkitson
Copy link
Member

clintkitson commented Mar 30, 2018 via email

@akutz
Copy link
Member

akutz commented May 18, 2018

Hi @jggc,

I'm happy to accept this PR, but please:

  1. Rebase onto master
  2. Split the current commit into two:
    • Commit 1 - Amazon Linux Support
    • Commit 2 - The global change to ${}

Thank you!

@akutz akutz self-assigned this May 18, 2018
@codenrhoden
Copy link
Member

Ping @jggc

Do you think you will make the requested changes?

@akutz
Copy link
Member

akutz commented Jun 11, 2018

Ping @jggc

@jggc
Copy link
Author

jggc commented Aug 13, 2018

Sorry missed the last notifiications. I'll try to get to that in the next couple weeks, no garantee though, feel free to pick up the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants