-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Amazon Linux support in installation script #1200
base: master
Are you sure you want to change the base?
Conversation
Amazon Linux works well with the RPM package and using the rpm package improves integration with the distribution. To do that I detect the distribution name in /etc/system-release. Also refactored the variables to be consistently using "${}" through the script.
Codecov Report
@@ Coverage Diff @@
## master #1200 +/- ##
=======================================
Coverage 34.25% 34.25%
=======================================
Files 36 36
Lines 2362 2362
=======================================
Hits 809 809
Misses 1450 1450
Partials 103 103 Continue to review full report at Codecov.
|
Thanks!
…On Fri, Mar 30, 2018 at 11:25 AM jggc ***@***.***> wrote:
Amazon Linux works well with the RPM package and using the rpm package
improves integration with the distribution. To do that I detect the
distribution name in /etc/system-release.
Also refactored the variables to be consistently using "${}" through the
script.
------------------------------
You can view, comment on, or merge this pull request online at:
#1200
Commit Summary
- Add Amazon Linux support in installation script
File Changes
- *M* install <https://github.com/rexray/rexray/pull/1200/files#diff-0>
(208)
Patch Links:
- https://github.com/rexray/rexray/pull/1200.patch
- https://github.com/rexray/rexray/pull/1200.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1200>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABVMMck6J9Be0boidp-RkgyQSWCIUJGxks5tjnh9gaJpZM4TB_ZL>
.
|
Hi @jggc, I'm happy to accept this PR, but please:
Thank you! |
Ping @jggc Do you think you will make the requested changes? |
Ping @jggc |
Sorry missed the last notifiications. I'll try to get to that in the next couple weeks, no garantee though, feel free to pick up the work. |
Amazon Linux works well with the RPM package and using the rpm package
improves integration with the distribution. To do that I detect the
distribution name in /etc/system-release.
Also refactored the variables to be consistently using "${}" through the
script.