Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe way to install #1106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Safe way to install #1106

wants to merge 1 commit into from

Conversation

kassanmoor
Copy link

Added a working example, and a troubleshooting point

Added a working example, and a troubleshooting point
@codecov-io
Copy link

codecov-io commented Nov 9, 2017

Codecov Report

Merging #1106 into master will increase coverage by 0.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1106      +/-   ##
=========================================
+ Coverage   34.16%   34.5%   +0.34%     
=========================================
  Files          36      36              
  Lines        2901    2901              
=========================================
+ Hits          991    1001      +10     
+ Misses       1807    1796      -11     
- Partials      103     104       +1
Impacted Files Coverage Δ
libstorage/api/types/types_localdevices.go 86.3% <0%> (+1.36%) ⬆️
...storage/drivers/storage/vfs/storage/vfs_storage.go 40.28% <0%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcae8ba...564ed86. Read the comment docs.

@akutz
Copy link
Member

akutz commented May 18, 2018

Hi @kassanmoor,

Please rebase this PR onto master. Additionally, please read the guide for contributing documentation. Some changes you need to make:

  • Please refrain from using pronouns. Passive voice is preferred.
  • Markdown should be limited to 80 characters per line.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants