Revert APITestCase defaulting to JSON format.
#208
+29
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 8, 2023 11:36
It reproduces issue reported in: revsys#205 `TestAPITestCaseDRFInstalled` only had tests for POST requests but the problem exposes itself on GET request.
Reproduced issue reported in comment: revsys#205 (comment)
- removed `TestAPITestCaseDRFInstalled.test_post_with_format_and_content_type` DRF doesn't allow passing both `format` and `content_type`. Removed test was promoting incorrect usage. - corrected `TestAPITestCaseDRFInstalled.test_post_with_content_type` According to DRF docs (https://www.django-rest-framework.org/api-guide/testing/#explicitly-encoding-the-request-body) using `content_type` requires explicitly encoding request body
`TestAPITestCaseDRFInstalled` tests make GET requests to this view.
DRF uses `multipart` by default for compatibility. https://www.django-rest-framework.org/api-guide/testing/#using-the-format-argument but for convenience it can be changed to json.
revsys#190 introduces a bug reported in: revsys#205 Also given that DRF already can handle serialization of json in post/put/patch/delete/options with `rest_framework.test.APIRequestFactory._encode_data` it's reasonable to assume `APITestCase.request` is redundant.
KaczuH
changed the title
APITestCase defaulting to JSON format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's an attempt to fix bug reported in #205
It's been introduced in #190
I've looked into it.
Changes i've introduced:
formatandcontent_typeoptions were used incorrectly)APITestCase.requestas it's redundant. In APITest case should default to JSON #81 the solution should be to recommend users to set default format in tests. DRF docsAll changes are explained in commit messages.
All nox tests pass locally.