Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add community keywords #1199

Merged
merged 2 commits into from
May 16, 2024

Conversation

dmijatovic
Copy link
Contributor

@dmijatovic dmijatovic commented May 14, 2024

Add keywords to community

Closes #1196

Changes proposed in this pull request:

  • Community maintainer can add keywords
  • The keywords are shown in the community card in the overview
  • The keywords are shown on the community page
  • Changed card design:
    • the number of software items is placed bottom right (similar to software card)
    • the keywords are added to card (similar to software card)

How to test:

  • make start to build and created test data
  • login as rsd admin
  • change community settings, add keywords. The keywords should be shown on the page
  • conform that keywords are also shown in the card

Example community overview using keywords

image

Example community settings with keywords

image

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed for 'rsd-database'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jmaassen
Copy link
Member

Few small comments:

  • adding keywords looks a bit weird, but good enough for now?
  • the keyword help text say "select from 30", but I only see 10 or so?
  • when I initially add keyword I get a pre-defined list, with things like "big data". If I select these, it works fine, but once I remove it, it's also removed from the pre-defined list.
  • when I select or remove a keyword, the counter is not updated until I leave the edit page.
  • when the about text is short, its centered on the page:

Screenshot 2024-05-14 at 14-34-55 4tu Research Software Directory

Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Failed Quality Gate failed for 'rsd-frontend'

Failed conditions
14.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@dmijatovic
Copy link
Contributor Author

@jmaassen Here are my answers

  • the keyword help text say "select from 30", but I only see 10 or so? It says (max.) top 30 :-). I can add word max but this approach is used for quite some time now and we have not had remarks about it
  • when I initially add keyword I get a pre-defined list, with things like "big data". If I select these, it works fine, but once I remove it, it's also removed from the pre-defined list. I cannot reproduce this behavior. Let's have a look at it together
  • when I select or remove a keyword, the counter is not updated until I leave the edit page. The counter is indicative and it does not reflect exact count. It is ment to suggest you the keywords that are used often
  • when the about text is short, its centered on the page. I think this looks nicer if the text is not wide see example bellow. I can change it if you insist but I think this looks better (see example below)

image

Copy link
Member

@jmaassen jmaassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, as Dusan convinced me these are features not bugs ;-)

@dmijatovic dmijatovic merged commit aa237e2 into 1184-community-settings May 16, 2024
5 of 6 checks passed
dmijatovic added a commit that referenced this pull request May 16, 2024
* feat: implement community settings page
chore: refactor maintainers sections
fix: do not show highlights section when javascript is disabled

* chore: add row level security for communities and improve database functions

* feat: add community keywords (#1199)

* feat: add community keywords

* chore: improve SQL and add keywords for communities to data generation

---------

Co-authored-by: Ewan Cahen <e.cahen@esciencecenter.nl>

---------

Co-authored-by: Ewan Cahen <e.cahen@esciencecenter.nl>
dmijatovic added a commit that referenced this pull request May 17, 2024
* feat: implement community settings page
chore: refactor maintainers sections
fix: do not show highlights section when javascript is disabled

* chore: add row level security for communities and improve database functions

* feat: add community keywords (#1199)

* feat: add community keywords

* chore: improve SQL and add keywords for communities to data generation

---------

Co-authored-by: Ewan Cahen <e.cahen@esciencecenter.nl>

---------

Co-authored-by: Ewan Cahen <e.cahen@esciencecenter.nl>
dmijatovic added a commit that referenced this pull request May 30, 2024
* feat: implement community settings page
chore: refactor maintainers sections
fix: do not show highlights section when javascript is disabled

* chore: add row level security for communities and improve database functions

* feat: add community keywords (#1199)

* feat: add community keywords

* chore: improve SQL and add keywords for communities to data generation

---------

Co-authored-by: Ewan Cahen <e.cahen@esciencecenter.nl>

---------

Co-authored-by: Ewan Cahen <e.cahen@esciencecenter.nl>
@dmijatovic dmijatovic deleted the 1196-community-keywords branch May 30, 2024 14:26
dmijatovic added a commit that referenced this pull request Jun 4, 2024
* feat: implement community settings page
chore: refactor maintainers sections
fix: do not show highlights section when javascript is disabled

* chore: add row level security for communities and improve database functions

* feat: add community keywords (#1199)

* feat: add community keywords

* chore: improve SQL and add keywords for communities to data generation

---------

Co-authored-by: Ewan Cahen <e.cahen@esciencecenter.nl>

---------

Co-authored-by: Ewan Cahen <e.cahen@esciencecenter.nl>
dmijatovic added a commit that referenced this pull request Jun 10, 2024
feat: implement community settings page
chore: refactor maintainers sections
fix: do not show highlights section when javascript is disabled
chore: add row level security for communities and improve database functions
feat: add community keywords (#1199)
feat: add community keywords
chore: improve SQL and add keywords for communities to data generation

---------

Co-authored-by: Ewan Cahen <e.cahen@esciencecenter.nl>

---------

Co-authored-by: Ewan Cahen <e.cahen@esciencecenter.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants