Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement community settings page #1195

Merged
merged 3 commits into from
May 16, 2024

Conversation

dmijatovic
Copy link
Contributor

@dmijatovic dmijatovic commented May 13, 2024

Community settings

Closes #1184

Changes proposed in this pull request:

  • Create community settings where maintainers can edit community settings or invite new maintainers
  • Refactor maintainers sections: created maintainers shared components and methods which are used by software, project, organisations and communities.
  • Additional unit tests for maintainer sections are created

How to test:

  • make start to build and generate test data
  • login as rsd-admin and navigate naar een community, or create new community from admin section
  • navigate to community settings and change the values, add primary maintainer
  • navigate to maintainers section, create invite links and use them with another user. Confirm the maintainer is added to the list. Confirm that regular maintainer does not see admin section of general settings.
  • removing maintainers: confirm that only rsd-admin can remove primary maintainer. The regular maintainer can remove itself or other maintainers but it cannot remove the last "regular" maintainer.
  • change the values in about page or remove about page completely by deleting the content
  • double check maintainers sections for: software, projects and organisations too.

Community settings

image

Community mantainers

image

Community about page

image

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

chore: refactor maintainers sections
fix: do not show highlights section when javascript is disabled
ewan-escience and others added 2 commits May 13, 2024 13:59
* feat: add community keywords

* chore: improve SQL and add keywords for communities to data generation

---------

Co-authored-by: Ewan Cahen <e.cahen@esciencecenter.nl>
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed for 'rsd-database'

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Failed Quality Gate failed for 'rsd-frontend'

Failed conditions
11.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@dmijatovic dmijatovic merged commit 443c1c2 into 616-communities May 16, 2024
5 of 6 checks passed
dmijatovic added a commit that referenced this pull request May 17, 2024
* feat: implement community settings page
chore: refactor maintainers sections
fix: do not show highlights section when javascript is disabled

* chore: add row level security for communities and improve database functions

* feat: add community keywords (#1199)

* feat: add community keywords

* chore: improve SQL and add keywords for communities to data generation

---------

Co-authored-by: Ewan Cahen <e.cahen@esciencecenter.nl>

---------

Co-authored-by: Ewan Cahen <e.cahen@esciencecenter.nl>
dmijatovic added a commit that referenced this pull request May 30, 2024
* feat: implement community settings page
chore: refactor maintainers sections
fix: do not show highlights section when javascript is disabled

* chore: add row level security for communities and improve database functions

* feat: add community keywords (#1199)

* feat: add community keywords

* chore: improve SQL and add keywords for communities to data generation

---------

Co-authored-by: Ewan Cahen <e.cahen@esciencecenter.nl>

---------

Co-authored-by: Ewan Cahen <e.cahen@esciencecenter.nl>
@dmijatovic dmijatovic deleted the 1184-community-settings branch May 30, 2024 14:26
dmijatovic added a commit that referenced this pull request Jun 4, 2024
* feat: implement community settings page
chore: refactor maintainers sections
fix: do not show highlights section when javascript is disabled

* chore: add row level security for communities and improve database functions

* feat: add community keywords (#1199)

* feat: add community keywords

* chore: improve SQL and add keywords for communities to data generation

---------

Co-authored-by: Ewan Cahen <e.cahen@esciencecenter.nl>

---------

Co-authored-by: Ewan Cahen <e.cahen@esciencecenter.nl>
dmijatovic added a commit that referenced this pull request Jun 10, 2024
feat: implement community settings page
chore: refactor maintainers sections
fix: do not show highlights section when javascript is disabled
chore: add row level security for communities and improve database functions
feat: add community keywords (#1199)
feat: add community keywords
chore: improve SQL and add keywords for communities to data generation

---------

Co-authored-by: Ewan Cahen <e.cahen@esciencecenter.nl>

---------

Co-authored-by: Ewan Cahen <e.cahen@esciencecenter.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants