-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1170 dedicated highlights page #1171
Conversation
63402e6
to
fe67781
Compare
4d046fa
to
9f70e1e
Compare
I made limit variable and added notification on the admin page. I set the limit to 5 items in settings.json. @cmeessen, @jmaassen and @ewan-escience Can you validate please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One typo, otherwise nice work.
9f70e1e
to
6d2cc38
Compare
chore: remove unused method
…uded in carousel on admin page chore: fix typo in component name docs: update documentation text to include limit
6856f4d
to
edda030
Compare
Quality Gate passed for 'rsd-database'Issues Measures |
Quality Gate failed for 'rsd-frontend'Failed conditions |
Works well, so go ahead and merge. Some points for improvement at a later time:
|
Dedicated highlights page
Fixes #1170
Changes proposed in this pull request:
settings.json
changes slightlyHow to test:
software_highlights
title and description insettings.json
docker compose down --volumes && docker compose build --parallel && docker compose up
docker compose run data-generation
Points to be regarded in followup PR:
PR Checklist:
docker-compose.yml