Sync settings after App installation #178
Conversation
|
|
||
| robot.on('installation_repositories.added', async context => { | ||
| const { payload } = context | ||
| const { repositories_added: repositories, installation } = payload |
There was a problem hiding this comment.
It seems that this is very similar to the installation event. Have you considered doing something like repositories = payload.repositories | payload.repositories_added and just combine the two events.
|
am i correct in understanding that this would directly update the file in the default branch? if so, it seems dangerous to do this without submitting the changes as a PR to give the repository maintainer a change to review and accept the changes. if a project already has the settings file, it's likely that there is a reason for it to include the contents that it does, even if it should be supplemented with additional details. |
|
What do you mean with directly updating the settings file? The flow this results in:
|
|
sorry, i definitely misunderstood the goal. i was thinking about the opposite situation where a repo without an existing file would have one created by pulling the existing settings for that repo through the api and written to the config file. i think there was an issue for that at one point, so i think i made the wrong assumption before reading deeply enough. with a better understanding now, i do see high value to this. i have been really busy lately, but will try to look through your PR soon and give feedback soon. |
mvegter
force-pushed
the
feature/app-installation-sync
branch
from
e36f4bd
to
5d17e60
Compare
mvegter
force-pushed
the
feature/app-installation-sync
branch
from
5d17e60
to
c3cdb68
Compare
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
|
sorry that i still havent gotten to this, but it is still on my radar |
|
Maybe ping @travi ? 😊 |
Fixes #1
Implementation has overlap with #179