Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the way the stream timeout is handled. More specifically:
setStreamTimeout
method once the stream has been created.setStreamTimeout
is removed.number_format
call for calculating the stream timeout is error-prone. It is replaced with int-casting and a call toround
.stream_set_timeout
emits a warning when float values are provided instead of ints. This solution ensures only ints are provided. The current solution and PR Fixes #129 Adding optional params to number_format #132 don't fully account for this situation.PHP_INT_MAX
.