Type consolidation and improvements #5319
Draft
Commits on Feb 13, 2024
-
Move types and coercion functions to own module
The content of the new types module is purely lift and shift, with the exception of references to other moved types. Some functions and methods have been reordered but the code is unchanged.
-
-
pos: Add explicit operator methods to position
This avoids other code needing to know or care about which operators are implemented directly and thus more performant and which are amalgams of other operators with additional overhead.
-
pos: Add support for equality checks to position
This is used by the transform interpolation code to identify which properties have changed. The lack of this method causes it to run no-op interpolations.
-
-
-
pos: Drop ATL *_or_none functions
The rationale for this is that they didn't serve their intended purpose, and somewhat misleading. They only called by interpolation, and in such a way that the argument could never be None. In 8.2 a special case was added to spline interpolation which used one of these functions directly, however the additional None handling failed to make the result any more usable. In order to address this in a more useful way, and align with non-spline interpolation, None values will now be treated as zero.
-
Expand dual angle operators and separate from_any
Same logic as for position, other code shouldn't have to worry which operators have first class support, and there are less mental hoops to jump through when we look back from years in the future.
-
Apply position type pattern to dualangle
Merges the DualAngle type and dualangle function removing the burden on calling code to appreciate the nuance and simply ask for a dualangle.
-
-
-
-
Ensure pickle safety for position and dualangle
We got away without defining __getnewargs__ in 8.2 because we didn't require arguments to __new__, but probably still ought to have done it. As pickled 8.2 types don't have the necessary arguments available to them, they require compat wrappers during unpickling.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.