Lint : Check reachable labels with required parameters

[Gouvernathor]

No description provided.

[mal]

It may not be pretty, but this is entirely legal and functional:

label start:
    call a(1)
    call alternate_greeting(2)
    return

label a(foo=1):
    "Hello [foo]"

label reentry(foo=1):
    "I'm conversing with [foo]."
    return

label alternate_greeting(foo=1):
    "Bonjour [foo]!"
    call reentry(foo)
    return

[renpytom]

I'd say even if it's legal, it's probably more likely to be an error than not.

[Gouvernathor]

None of the labels in that example emit a lint warning, even if they were all reachable (which they are not, only reentry is), since none of them have a required parameter.

[Gouvernathor]

My test code would be this :

label entry:
label fine:
label finetoo():
label also(e=5):
label problem(f):
    pass

the entry label is not reachable by other means than jumping to it (assuming it's the start of the file). fine, finetoo and also have no required parameter, so reaching them "from the top" is fine (even though weird in the case of also), and only problem is reported by lint.

[mal]

Fair enough, I'm just always wary of lint accidentally becoming an opinionated "we don't think you want to do this" (weird label structuring) tool vs a "these are actual problems" (using attributes that don't exist) tool.

[Gouvernathor]

I agree, I aimed for the second one.

Note that this is a prototype to illustrate how the base issue can be solved and help consideration of that issue, I don't strongly support adding that check or that particular implementation.