New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testcase #4630
Draft
Gouvernathor
wants to merge
88
commits into
master
Choose a base branch
from
testcase-ex
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Testcase #4630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Tom Rothamel <pytom@bishoujo.us>
Co-Authored-By: Tom Rothamel <pytom@bishoujo.us>
We don't support subpixel, sure, but this is faster and more "correct" if any absolute finds its way through. Also there's no need to cast to int if we're doing it afterwards anyway.
In case of an exception
That way we have an or-neutral element (and not pass is the and-neutral element)
the re-setting of the value is there to make sure a save is loaded at all, and the value check to make sure it was the correct save that was loaded
Gouvernathor
added
the
enhancement
A proposed or requested enhancement or improvement to renpy's features.
label
May 13, 2023
it would always end up executing an unready clause
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do :
Possible improvements (various ideas, sometimes contradictory, may be left to future PRs) :
config
or something else (all the public testcases in alphabetical order for example) store a list of testcases, defaulting to("default",)
, to execute in sequence when clicking the "launch tests"Currently, the "Launch tests" button on the launcher, just below Lint, launches the default testcase and that's it.