Make it possible to pass rpyc version value as an argument #4572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note for myself. This could cause |
|
I'm not convinced that this is correct (that is, that it will wind up with the same .rpyc files for different members of the team), at least in the case where someone updates through multiple revisions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main use-case for that is to run
renpy --compile --rpyc-version int(HEAD_COMMIT_SHA, 16)in Git environment (by git pull/checkout hook or other means), so we have the same rpycs content between members without involving of old-game (I used that approach and it wasn't very convenient).I don't think it makes old-game obsolete, because for non-techie it is easier to copy and paste folders with rpycs then playing with console.